Skip to content

feat(let): add strftime function #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2025
Merged

feat(let): add strftime function #1373

merged 4 commits into from
Nov 11, 2025

Conversation

@mesejo
Copy link
Collaborator

@mesejo mesejo commented Nov 5, 2025 •
edited
Loading

closes #1372

@mesejo mesejo marked this pull request as draft November 5, 2025 12:14
@mesejo mesejo self-assigned this Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
python/xorq/backends/let/datafusion/udfs.py 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
python/xorq/backends/let/datafusion/compiler.py 88.28% <100.00%> (+0.07%) ⬆️
python/xorq/backends/let/tests/test_temporal.py 100.00% <100.00%> (ø)
python/xorq/backends/let/datafusion/udfs.py 59.21% <83.33%> (+2.06%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 5, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1373 will improve performances by ×2

Comparing feat/add_strftime (6659431) with main (d5081fa)

Summary

⚡ 1 improvement
✅ 3 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_into_backend_cache 477.8 ms 235.1 ms ×2

@mesejo mesejo requested a review from hussainsultan November 5, 2025 13:19
@mesejo mesejo marked this pull request as ready for review November 5, 2025 13:19
dlovell
dlovell reviewed Nov 5, 2025
View reviewed changes
@mesejo mesejo requested a review from dlovell November 6, 2025 15:10
dlovell
dlovell reviewed Nov 10, 2025
View reviewed changes
@dlovell dlovell merged commit 8c0e67d into main Nov 11, 2025
23 checks passed
@dlovell dlovell deleted the feat/add_strftime branch November 11, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlovell dlovell dlovell approved these changes

@hussainsultan hussainsultan Awaiting requested review from hussainsultan

Assignees

@mesejo mesejo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compilation rule for 'Strftime' operation is not defined

3 participants

@mesejo @dlovell